Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Waveshare S3 Zero pins.c to add BOOT button #9858

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Update Waveshare S3 Zero pins.c to add BOOT button #9858

merged 4 commits into from
Dec 9, 2024

Conversation

Timeline8
Copy link

@Timeline8 Timeline8 commented Dec 3, 2024 •
edited
Loading

Currently the BOOT button, which is labeled simply as "B" on the silkscreen, is not defined in the BOARD module of Circuit{Python and therefore to use this button as an input requires

import microcontroller
from digitalio import DigitalInOut
button = DigitalInOut(microcontroller.pin.GPIO0)

This change adds "BUTTON" & "D0" aliases for the GPIO0 pin.

For reference, Waveshare ESP32-S3-Zero schematic is here: https://files.waveshare.com/wiki/ESP32-S3-Zero/ESP32-S3-Zero-Sch.pdf

@Timeline8
Update pins.c to add BOOT button
00cec1c 
Currently the BOOT button is not defined as it is on most board. Added BUTTON & D0 aliases for the GPIO0 pin.
@Timeline8
Update pins.c for BOOT button on Waveshare S3 Zero
593d6e4 
Currently the boot button is not defined. Adding BUTTON and D) aliases.
tannewt
tannewt requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

ports/espressif/boards/waveshare_esp32_s3_zero/pins.c Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Thanks!

@tannewt tannewt merged commit 4c0fb4c into adafruit:main Dec 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timeline8 @tannewt